search

nomad-coe / nomad

NOMAD lets you manage and share your materials science data in a way that makes it truly useful to you, your group, and the community.
https://nomad-lab.eu
Apache License 2.0
71 stars 16 forks source link

updated to the newest minor version of some of the docker images #43

Closed BlackLotus closed 9 months ago

BlackLotus commented 1 year ago

I didn't yet test major updates, but couldn't find any problems with updating the minor versions. Would it be desirable to combine both docker compose files so that the keycloak file just uses an extend?

markus1978 commented 1 year ago

@fekad I am sure you have an opinion about the merge of the two docker-composes?

@BlackLotus with "extend", you mean this docker-compose.yaml + docker-compose.keycloak.yaml docker feature?

markus1978 commented 1 year ago

I close and open the PR to trigger our new github actions.

github-actions[bot] commented 1 year ago

A merge request has been opened on gitlab. View the GitLab merge requests. This will run CI/CD pipelines, we will continue the discussion, and merge on GitLab. After the merge has completed on GitLab, the changes will be pushed to develop here.

markus1978 commented 9 months ago

We will not do this if there is no actual problem attached.