search

nomad-coe / nomad

NOMAD lets you manage and share your materials science data in a way that makes it truly useful to you, your group, and the community.
https://nomad-lab.eu
Apache License 2.0
71 stars 16 forks source link

last commit to develop breaks local parser #44

Closed mdforti closed 1 year ago

mdforti commented 1 year ago

parsing locally was working before e98eeb26b7ea43ee2d6e424fc8c3131097d48c00

now it gives this error:

Traceback (most recent call last): File "Tests/test_workflow_creator.py", line 9, in from nomad.client import parse, normalize_all File "/data/git/nomad/nomad/client/init.py", line 19, in from .archive import ArchiveQuery File "/data/git/nomad/nomad/client/archive.py", line 28, in from nomad import config, metainfo as mi File "/data/git/nomad/nomad/config.py", line 334, in north = North() File "pydantic/main.py", line 339, in pydantic.main.BaseModel.init File "pydantic/main.py", line 1038, in pydantic.main.validate_model File "pydantic/fields.py", line 840, in pydantic.fields.ModelField.validate File "pydantic/fields.py", line 1121, in pydantic.fields.ModelField._apply_validators File "pydantic/class_validators.py", line 280, in pydantic.class_validators._generic_validator_cls.lambda3 File "/data/git/nomad/nomad/config.py", line 328, in load_tools with open(v, 'rt') as f: FileNotFoundError: [Errno 2] No such file or directory: 'dependencies/nomad-remote-tools-hub/tools.json'

mdforti commented 1 year ago

reverting to 90de7a970ceef586936231a6334ac602d8344be8 makes it work again

markus1978 commented 1 year ago

Can you detail locally? Did you clone the project and did a setup as described in the documentation? Or did you pip install the nomad-lab python package?

If its the first case, does the file dependencies/nomad-remote-tools-hub/tools.json exist in your cloned project? Are all the submodules (esp. dependencies/nomad-remote-tools-hub) updated?

mdforti commented 1 year ago

file is there

mdforti commented 1 year ago

I followed this instructions: https://nomad-lab.eu/prod/v1/staging/docs/develop/setup.html as mentioned in this issue: https://github.com/nomad-coe/nomad/issues/39

mdforti commented 1 year ago

this fixes for me: https://github.com/mdforti/nomad/commit/c9fab17cb00e670207bac008a18f7999448962c4

mdforti commented 1 year ago

Were you able to check this ? Just a little context, I am trying to make a python script to generate a equation_of_state workflow archvie.json, similar to this test:

https://github.com/nomad-coe/nomad/blob/develop/tests/normalizing/conftest.py#L636

That is my test_workflow_creator in the traceback.

TLCFEM commented 1 year ago

https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/issues/1353

markus1978 commented 1 year ago

We are currently working on getting rid of this file entirely. https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1117

Andrew-S-Rosen commented 1 year ago

I think this can be closed now! 😄