search

nomad-coe / nomad

NOMAD lets you manage and share your materials science data in a way that makes it truly useful to you, your group, and the community.
https://nomad-lab.eu
Apache License 2.0
71 stars 16 forks source link

Fix formatting error message #48

Closed ericpre closed 1 year ago

ericpre commented 1 year ago

Noticed it in the following error message:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/nomad/normalizing/metainfo.py", line 35, in normalize_section
    normalize(self.entry_archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/datamodel/metainfo/eln/__init__.py", line 92, in normalize
    super(ElnBaseSection, self).normalize(archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/datamodel/data.py", line 82, in normalize
    super(EntryData, self).normalize(archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 103, in normalize
    self.tabular_parser(quantity_def, archive, logger, annotation)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 130, in tabular_parser
    parse_columns(data, self)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 284, in parse_columns
    'The sheet name {sheet_name} doesn''t exist in the excel file')
ValueError: The sheet name {sheet_name} doesnt exist in the excel file

Even if this is not used in this specific case, I removed the use of f-string with the logger, as this pattern is discouraged.

markus1978 commented 1 year ago

Thanks for the PR. The change makes sense. Please have some patience as we are still figuring out how to deal with these PRs and our two git-repositories.

markus1978 commented 1 year ago

I will close and reopen the PR and try to trigger our new sync with the GitLab.

github-actions[bot] commented 1 year ago

A merge request has been opened on gitlab. View the GitLab merge requests. This will run CI/CD pipelines, we will continue the discussion, and merge on GitLab. After the merge has completed on GitLab, the changes will be pushed to develop here.