Rename invalid file name on windows?

nomad-coe / nomad

NOMAD lets you manage and share your materials science data in a way that makes it truly useful to you, your group, and the community.

https://nomad-lab.eu

Apache License 2.0

71 stars 16 forks source link

Rename invalid file name on windows? #49

Closed ericpre closed 1 year ago

ericpre commented 1 year ago

The following files seems to be invalid on windows (most likely because of the : character) and this causes issue with cloning the repository on windows:

tests/data/parsers/aflow/Ag1Co1O2_ICSD_246157/aflow:fbc2cf03b9659c90.json
tests/data/parsers/aflow/Ag1Co1O2_ICSD_246157/aflow:fbc2cf03b9659c90.out

Would it make sense to remove the character : from the name of these files?

markus1978 commented 1 year ago

@ladinesa this should be easy, right?

ladinesa commented 1 year ago

Fixed.

ericpre commented 1 year ago

Thanks, this is working fine now.