nomad-coe / nomad

NOMAD lets you manage and share your materials science data in a way that makes it truly useful to you, your group, and the community.
https://nomad-lab.eu
Apache License 2.0
64 stars 14 forks source link

Javascript error while searching through custom schema quantities #74

Closed fabianli789 closed 11 months ago

fabianli789 commented 11 months ago

Hello. I've uploaded a .yaml schema that looks like this:

definitions:
  sections:
    Process:
      quantities:
        time:
          type: Datetime
    Evaporation:
      base_section: Process
      quantities:
        pressure:
          type: np.float64
          unit: Pa
    Annealing:
      base_section: Process
      quantities:
        temperaturee:
          type: np.float64
          unit: K
data:
  m_def: Annealing
  time: '2022-10-14 12:00:00'
  temperaturee: 123.321

Temperature has intentionally been written as temperaturee with double e to make it easier to find. Then on the Nomad website, I go to Explore, ELN, then search for user defined quantities. temperaturee does show up as suggested quantity, but clicking on it leads to a javascript error.

markus1978 commented 11 months ago

Thanks for the report. I can reproduce this. On our staging server there is a different problem, but it does also not work.

@mohammadnakhaee please have a look.

lauri-codes commented 11 months ago

@blueraft : Would you have time to look at this? At least create a Gitlab issue + branch and have a look if you can make sense of the javascript error. I can also help out and then do the review.

blueraft commented 11 months ago

Sure! I'll try to figure out a fix for this.

lauri-codes commented 11 months ago

The related issues in GitLab are: #1613 (closed), #1632 (closed) and #1644 (open).

lauri-codes commented 11 months ago

@fabianli789: The issue is now fixed in our beta deployment found here: https://nomad-lab.eu/prod/v1/staging/gui/search/entries

Eventually, the fix will also be a part of the next production update.