search

nomad-hzb / nomad-chemical-energy

Apache License 2.0
1 stars 1 forks source link

Move parsers from baseclasses to plugin #13

Closed carla-terboven closed 3 months ago

carla-terboven commented 4 months ago

This PR solves issue https://github.com/nomad-hzb/nomad-chemical-energy/issues/11

I am not sure if I should move the gamry_parser.py file here since it is also used in the nomad-chemical-energy-parser. Any ideas regarding that?

RoteKekse commented 4 months ago

We could join the two repos into one.

see https://github.com/nomad-hzb/hzb-combinatorial-libraries-plugin/tree/pixel/src/hzb_combinatorial_libraries how this looks like in thelibrary plugin

historically this was not possible

carla-terboven commented 3 months ago

Ok, sounds like useful refactoring. I can move all files from the nomad-chemical-energy-parser to the places in nomad-chemical-energy.

RoteKekse commented 3 months ago

Note that i add a new gamry parser for LSG