nomad-hzb / nomad-chemical-energy

Apache License 2.0
1 stars 1 forks source link

add csv option to uvvis measurement #5

Closed carla-terboven closed 6 months ago

carla-terboven commented 6 months ago

I have used already existing baseclasses. But I am not sure if they are entirely correct because the plot in UVVisData has a strange unit on the x-axis. The wavelength is read in nm, but the plot shows values that are 10 times as large and the unit is displayed as Å.

carla-terboven commented 6 months ago

Ok I found that Å is an actual unit and that it can be converted to the correct values in nm. So the problem has resolved itself.

RoteKekse commented 6 months ago

@carla-terboven please add a plot alread to the overview, right now it is only in the subsection

carla-terboven commented 6 months ago

The delimiter in the pd.read_csv is different thats why I decided to do it like this.

RoteKekse commented 6 months ago

ah ok, i looked very hard but didnt see it :D , then please set the delimiter

delimiter = "," if os.path.splitext(data_file)[-1] ".csv" else "  "

to repeat as little code as possible.

carla-terboven commented 6 months ago

I don't know how to add the plot because there can be multiple measurements. Right know I added a plot with axis but it is not showing anything because I need something like measurements[0]/intensity. But this is not working.

carla-terboven commented 6 months ago

Ok I found the solution for the plot.

carla-terboven commented 6 months ago

ah ok, i looked very hard but didnt see it :D , then please set the delimiter

delimiter = "," if os.path.splitext(data_file)[-1] ".csv" else "  "

to repeat as little code as possible.

Oh I see. That would have been even nicer.