search

nomad-software / tkd

GUI toolkit for the D programming language based on Tcl/Tk
MIT License
117 stars 16 forks source link

package.json windows pregenerate #23

Closed callumenator closed 10 years ago

callumenator commented 10 years ago

Looks these are wrong on your repo readme:

"postGenerateCommands-windows-x86": [
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86\\tcl86.dll build\\tcl86.dll /y",
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86\\tk86.dll build\\tk86.dll /y",
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86\\zlib1.dll build\\zlib1.dll /y",
    "xcopy $TCLTK_PACKAGE_DIR\\dist\\library build\\library /i /e /y",
],
"postGenerateCommands-windows-x86_64": [
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86_64\\tcl86.dll build\\tcl86.dll /y",
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86_64\\tk86.dll build\\tk86.dll /y",
    "copy $TCLTK_PACKAGE_DIR\\dist\\x86_64\\zlib1.dll build\\zlib1.dll /y",
    "xcopy $TCLTK_PACKAGE_DIR\\dist\\library build\\library /i /e /y",
],

should be tcl86t.dll, tk86t.dll, and zlib is not present

callumenator commented 10 years ago

Also, to avoid recopying all the time, the "/d" flag can be added to xcopy to only copy over newer files. Just a suggestion.

nomad-software commented 10 years ago

These files are actually correct.

Currently Tkd uses v8.6.2 of tcltk in the package.json file. These files do indeed exist in that version. The current version of tcltk (8.6.3) uses the files you have referenced. Tkd will use the new files when the new version of dub is released (which shouldn't be long.) When the new version of dub is released, the copy commands will become a standard part of the tcltk package.json. The xcopy issue was deliberate to make sure all are copied each time.

See later comments in https://github.com/nomad-software/tkd/issues/22

callumenator commented 10 years ago

Ah ok. But currently, the building instructions on code.dlang.org did not work for me because of the dll naming issue. Cheers

nomad-software commented 9 years ago

I've now amended these and updated the release.