search

nomad-software / tkd

GUI toolkit for the D programming language based on Tcl/Tk
MIT License
117 stars 16 forks source link

Changes to setFont(), updated example.d with a new customization notebook tab. #53

Closed AndrewGrim closed 5 years ago

AndrewGrim commented 5 years ago

I'm assuming you haven't seen my comment.

Long story short: I think its best to change setFont() to accept just a single argument because it makes it trivial to use the fontDialog whilst avoiding multiple functions that do the same thing, and personally I find it pretty easy to read and write.

Let me know what you think about this change.

nomad-software commented 5 years ago

Instead of replacing the existing setFont method, I've added a new overload to do the same thing. You may need to rebase.

AndrewGrim commented 5 years ago

I really like your change, I was not aware of overloading before. I take it that the mixin color changes should be a different pull request?