Hey! I found a little issue where building a rope using the builder would result in different line lengths compared to constructing the Rope directly (using Rope::from).
Buffer::has_trailing_newline transitively depends on len_left which depends on left_summary being up to date. However, Builder::finish was calling them in the reverse order so this wouldn't work in some cases.
Since has_trailing_newline is now false instead of true, the line length is too great by 1.
noib3
commented
5 months ago
Hey! I found a little issue where building a rope using the builder would result in different line lengths compared to constructing the Rope directly (using
Rope::from).Buffer::has_trailing_newlinetransitively depends onlen_leftwhich depends onleft_summarybeing up to date. However,Builder::finishwas calling them in the reverse order so this wouldn't work in some cases.Since
has_trailing_newlineis now false instead of true, the line length is too great by 1.