search

nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

Empty sidebar pulls the page content to the left #16

Closed karamellpelle closed 3 years ago

karamellpelle commented 3 years ago

Nice template, thanks!

If I only use the config setting Content for sidebarLeftRow1,sidebarLeftRow2,sidebarLeftRow3 or sidebarLeftRow4, and there is no content in the sidebar (or all these are set to None), the page content is pulled all the way to the left, over the sidebar area. I guess this is wrong (at least I want the page content on the right side of the sidebar).

nomadjimbob commented 3 years ago

If you have no sidebar content (either in a page, or by setting all of the rows to None in the config) then the sidebar is not shown as there is nothing to show.

Are you saying that you want the theme to always show a sidebar, even when there is no content to show in the sidebar?

karamellpelle commented 3 years ago

Yes, I always want a sidebar. Because some namespaces have a sidebar, and some don't. This makes the layout consistent for my site.

Also, the sidebar is still shown (as a colored frame) when there is no sidebar, but the page content is wrapped over it, at the top.

karamellpelle commented 3 years ago

An easy solution to my problem is to create a sidebar with an empty character. Works well!

nomadjimbob commented 3 years ago

The current master now has the option to always show the sidebar (left and/or right) even when there is no content. The option is disabled by default not to break current installs.

The rouge sidebar overflow issue should also be fixed.

When tested over the next few days, an official release will be done

nomadjimbob commented 3 years ago

An easy solution to my problem is to create a sidebar with an empty character. Works well!

Yeah, as long as there is some kind of content present, then it will write out the sidebar code. Still a work around and not ideal for larger sites for how you want it to work. The current master now has an option to always show the sidebar, even when there is no content.