search

nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
23 stars 6 forks source link

Back and View Page links should support userewrite setting #19

Closed stephen-hill closed 3 years ago

stephen-hill commented 3 years ago

The href's on lines 983 and 985 of mikio.php do not support friendly/pretty urls: https://github.com/nomadjimbob/mikio/blob/f3c1f923cba22ef8b796ab12ee579854161ea88f/mikio.php#L983-L985

I've modified these lines to support pretty urls for my install, but it would be nice if this was fixed to support the different url types documented here https://www.dokuwiki.org/config:userewrite.

This is how I modified mine. Please note this is specific to my install and does not take userewrite into account.

          } else {
              $html .= '≪ ';
              if(isset($_GET['page'])) {
                  $html .= '<a href="/' . $_GET['id'] . '?do=' . $_GET['do'] . '">Back</a>' . '&nbsp;&nbsp;&nbsp;/&nbsp;&nbsp;&nbsp;';
              }
              $html .= '<a href="/' . $_GET['id'] . '">View Page</a>';
          }
nomadjimbob commented 3 years ago

These 2 lines should probably be using the wl function instead of directly referencing $_GET['id']. I'll test it out later today and get this fixed ASAP

nomadjimbob commented 3 years ago

Thats for reporting this issue.

Release 2021-03-10 corrects the problem with sites using userewrite.

stephen-hill commented 3 years ago

@nomadjimbob I just want to say thank you for fixing this minor issue so quickly and thank you for creating a really nice DokuWiki template.