search

nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

Icon and graphic scaling is broken #20

Closed hubdot closed 3 years ago

hubdot commented 3 years ago

After installing Mikio and enabling it the theme icons get shown at maximum size and don't get scaled. Tested various browsers (Edge, Firefox etc.) with the same effect.

Picture of how it looks: https://i.imgur.com/He8uBAQ.png

hubdot commented 3 years ago

Update: it's resolved if switched to useLESS "checked" in Admin > Configuration Settings "tpl»mikio»useLESS Use the LESS compiler for the mikio stylesheet or direct CSS. Requires PHP ctype extensions installed"

I have discovered some other issues but will create new issues for those.

nomadjimbob commented 3 years ago

I'm going to reopen as the scaling of graphics should not happen regardless of this setting. If your version of PHP does not have the ctype library installed, then it should always revert to not using LESS.

I'll look further into why this was not the case for you.

nomadjimbob commented 3 years ago

Mikioplugin also uses a LESS formatter that supports PHP versions that does not have ctype extensions installed. For some reason, this was never back-added to the Mikio theme.

I have now pulled that code and made it into its own repository and will add it into Mikio which will support fixes for some of the currently open issues.

nomadjimbob commented 3 years ago

polyfill-ctype library is now used and referenced in the LESS code. The commit 692c64c68c7c70af23c028b06fcdb4bf5f72aab4 also adds support for symbolic links and supports a fall back to the mikio.css asset instead of no stylesheet at all.

Mikio admin will also now display a message is LESS is not supported on your server