mikio-page-fill lacks esthetic sense

karamellpelle commented 3 years ago

<div class="mikio-page-fill"> fills out the page such that the footer stays at the bottom. However, this makes the page look odd, there is just empty space, see attached image. It would look more natural if mikio-page padded itself to the bottom so that mikio-sidebar and mikio-content fiils to the footer. I didn't have this problem before I updated.

nomadjimbob commented 3 years ago

This was by design for the original project, however I do agree with you. As it is an expectation that the theme will be rendered this way, such a change would need to be an option that is disabled by default to not break any existing sites.

Ill add it into the next release, however for the time being you could add the CSS (was a quick put together, may depend on what other changes to the CSS you have made, sorry if i got it wrong):

.mikio-page-fill {
    display: none;
}

.mikio-page {
    display: flex;
    flex-grow: 1;
}

@media (max-width: 768px) {
    .mikio-page {
        display: block;
    }
}

karamellpelle commented 3 years ago

Thank you! I also needed to add

// fill horisontally (parent is flex container)
.mikio-container
{
    flex: 1; 
}

otherwise the content in .mikio-page became centered.

nomadjimbob / mikio

mikio-page-fill lacks esthetic sense #28