search

nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

Fixed searching for images in the theme directory #42

Closed cmacmackin closed 2 years ago

cmacmackin commented 2 years ago

The way Template->getMediaFile() was written meant that, when looking for media files in the theme directory, it prepended the absolute path of the template directory twice. E.g., it would be looking for a file at /home/username/public_html/lib/tpl/mikio//home/username/public_html/lib/tpl/mikio/themes/themename/images/logo.png rather than simply /home/username/public_html/lib/tpl/mikio/themes/themename/images/logo.png. This pull request fixes that bug. It also clarifies the documentation in the README about where exactly the images can be placed.

cmacmackin commented 2 years ago

Note: the page for this template on the Dokuwiki website should be updated with the revised wording from the README if this PR is accepted.

nomadjimbob commented 2 years ago

Thank you for your PR and support. Added to the current release 2022-05-05 as well as updated the Dokuwiki page.