nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
23 stars 6 forks source link

Area around TOC seems to be rendered incorrectly #49

Closed vitaprimo closed 1 year ago

vitaprimo commented 1 year ago

I spent quite a bit of time trying to find what color to change to get rid of the shadow-like border around the TOC but I just couldn't do it. From screenshots I took the color with a design app, but the color wasn't on any of the boxes in the styles section.

Finally I reset everything, judging from the screenshots on the theme's description, I figured it should look like that it was reset to defaults, but of course I wouldn't be here it that had succeeded.

I think it's not supposed to look like that. I attached a giant screenshot of the issue on a couple of browsers…and old Safari.

Screen Shot 2022-12-09 at 13 38 53 PM

nomadjimbob commented 1 year ago

The box shadow is not configurable through any admin interface, however you can add a sub-theme to remove it from the TOC.

Create the folder/file within the template at \lib\tpl\mikio\themes\noshadow\style.css with the following contents:

.mikio .mikio-toc #dw__toc {
    box-shadow: none;
}

Then in the admin interface, set the customTheme to noshadow

Screenshot 2022-12-12 at 10 09 16 am

that will override the mikio styling and not impact any future updates.

I am not sure what you are showing me with the screenshots? Are you wanting to reset the custom colours you have set?

You can delete the file created by Dokuwiki in \conf\tpl\mikio\style.ini. This file will contain all the default mikio colour settings (which is located at \lib\tpl\mikio\style.ini) with any custom settings you have also set. By deleting this file, you will remove any custom colours you have applied to Mikio, reverting the template back to default.

RonaldPR commented 1 year ago

We are having the exact same issue, but it is not the shadow.

Empty scroll bars appear to the right and at the bottom of the Table of Contents when in the Configuration Settings the Table of Contents is set to "Show the TOC as a full height element"

At first only Windows users of our wiki reported seeing this anomaly in various web browsers, while I did not see it in macOS. Only after I set in System Preference (System Settings in Ventura) "Show scrol bars" to "Always" these empty scroll bars also appeared in macOS, in all my web browsers.

Creating and enabling the noshadow theme as described did make the shadow go away, leaving only the border, but it did not make the empty scroll bars go away.

For now, I disabled "Show the TOC as a full height element", but it would be nice to be able to use this functionality without this visual issue.

RonaldPR commented 1 year ago

Maybe the cropped screenshots by vitaprimo do not show the issue clearly. Here are two screenshots from full browser windows;

In Chrome for Windows: https://www.toeflresources.com/wp-content/uploads/2023/05/Screenshot-2201.png In Windows the issue was seen in Chrome, Firefox, and SeaMonkey.

In Safari for macOS: https://ronaldpr.home.xs4all.nl/emaculation/Screenshot_2023-05-08.png In macOS the issue was seen in Safari, Firefox, iCab, and SeaMonkey.

Note that this visual anomaly only appears when in the Configuration Settings, Table of Contents, "Show the TOC as a full height element" is enabled.

In macOS the anomaly will only be manifest if also in System Preferences (System Settings in Ventura) "Show scrol bars" is set to "Always"

I hope something can be done about this issue as using the TOC as "full height element" is otherwise a nice feature with the TOC staying next to the article when one scrolls down.

nomadjimbob commented 1 year ago

Thanks for letting me know and showing the screenshots. It looks like I have fixed this issue and will be pushed to Dokuwiki in the next hour or so. If it persists, please let me know

RonaldPR commented 1 year ago

This issue is indeed solved. Thanks.

Op 10 mei 2023, om 23:12 heeft James Collins @.***> het volgende geschreven:

Thanks for letting me know and showing the screenshots. It looks like I have fixed this issue and will be pushed to Dokuwiki in the next hour or so. If it persists, please let me know

— Reply to this email directly, view it on GitHub https://github.com/nomadjimbob/mikio/issues/49#issuecomment-1542816285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOMQUQEFKCKRV6UVCXNWG3XFQAEBANCNFSM6AAAAAASZ7TCLE. You are receiving this because you commented.