nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

Background color for table heading rows does not work #50

Closed RonaldPR closed 1 year ago

RonaldPR commented 1 year ago

While playing with Template Style Settings, I found that "The background color for table heading rows" does not work.

Regardless the chosen color, the background color in table heading rows remain the same as the main background color, #ffffff in Light mode and #222222 in Dark mode.

The generated html looks OK to me (heading row plus first row):

                                    <div class="table sectionedit3">
                                        <table class="inline">
                                            <thead>
                                                <tr class="row0">
                                                    <th class="col0"> Guest </th>
                                                    <th class="col1"> Default build </th>
                                                    <th class="col2"> Sound-enabled build </th>
                                                    <th class="col3"> Specific arguments </th>
                                                    <th class="col4"> Remarks </th>
                                                </tr>
                                            </thead>
                                            <tr class="row1">
                                                <td class="col0 leftalign"> Mac OS 9.0         </td>
                                                <td class="col1 leftalign"> OK            </td>
                                                <td class="col2 leftalign"> Needs -cpu G3          </td>
                                                <td class="col3"> -M mac99 </td>
                                                <td class="col4"> Requires rom version 5.2.1 or above, mouse wiggle to boot </td>
                                            </tr>

So I suppose it is a css issue

Also a minor textual error in the style settings page, both with light mode and dark mode settings: The background color for table odd rows The background color for table odd rows

The second one should be named The background color for table even rows

nomadjimbob commented 1 year ago

Thanks for letting me know. The latest update fixes this issue and exposes table text colouring options incase the base text colour does not work with the header/row background colours.

RonaldPR commented 1 year ago

Perfect! Thank you.

Mabe you would like to see what we did with your template: https://www.emaculation.com/doku.php

and an article with table https://www.emaculation.com/doku.php/ppc-osx-on-qemu-for-osx

Thanks again.

Op 13 mei 2023, om 01:18 heeft James Collins @.***> het volgende geschreven:

Thanks for letting me know. The latest update fixes this issue and exposes table text colouring options incase the base text colour does not work with the header/row background colours. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

nomadjimbob commented 1 year ago

Awesome work. Thanks for the nostalgia trip back to when I used to own a Mac Classic II with System 6, trying to make games in Hypercard!

If there are any improvements you would like to see in this theme, or the MikioPlugin, don't hesitate to open an issue.