search

nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

No provision for messages #58

Closed schplurtz closed 2 months ago

schplurtz commented 7 months ago

When displaying pages, mikio does not display messages sent by the msg DokuWiki function.

With another template, I can see the messages on the page, but not with mikio. Do the test with this test wiki: https://pamarei1zai7phaop.bidule.https443.net/start?do=check

We expect to see something like this, but there is nothing instead:

image
nomadjimbob commented 7 months ago

Mikio supports the msg function. As with #57, can you provide the version of DokuWiki and a list of Dokuwiki plugins so I can try and replicate the issue you are experiencing?

Screenshot 2023-12-11 at 5 25 37 am
schplurtz commented 6 months ago

good evening,

This happens on both the current stable DW release and the current snapshot release. No extensions except mikio template and mikio plugin.

On your configuration manager screenshot, there is a message. I observe the same thing, no problem in configuration manager when I save the config. But on standard wiki page, messages don't show.

I took a quick look at the code. It appears that there is no call to html_msgarea in lib/tpl/mikio/main.php . That's why messages aren't displayed on standard pages.

nomadjimbob commented 6 months ago

Thanks. I will add that in over the next few days (we have a Cyclone/Typhoon warning in place at the moment).

I want to also fix the jQuery issue in the external typeahead library you raised in another issue, testing it against the snapshot in the same release.

schplurtz commented 6 months ago

Great ! Good luck with the Typhoon.

nomadjimbob commented 6 months ago

I've gone through my code to work it how I've missed this. Mikio has a showMessages method that directly prints the messages on normal pages provided the config is setup to do this. By default, Mikio will only print messages on admin pages. If you go into the config and change the showMessages value from admin to always then it will work as expected.

This has revealed a bug, the config should be a dropdown of options, not a text field, so the next release fixes this.

The next release will also default to always instead of admin so that it mimics Dokuwiki as default.

I believe I went around html_msgarea() and printed messages manually due to an issue in older versions (it could of just been a brain-fart at the time), something I need to test before the release in a few days.

nomadjimbob commented 2 months ago

Fixed in an earlier release