nomadjimbob / mikio

Customizable, Bootstrap 4 inspired template for Dokuwiki
GNU General Public License v2.0
22 stars 6 forks source link

Stickiness config not applied correctly #74

Open macin opened 1 month ago

macin commented 1 month ago

Hi, I have applied all the stickiness configs available and it seems not to work correctly.

This is how it works on my env. 2024-06-06_07h47_50

I would expect that neither the breadcrumbs, nor the content and sidebar would hide under the top bar. Is this something that can be fixed?

nomadjimbob commented 1 month ago

This is correct functionality.

stickyTopHeader - This is the top header above the navbar (which is not present on your page) stickyNavbar - The navbar (top bar) is being sticky in your env here. It is stuck to the top of the view with content going under it stickyHeader - The header sits between the navbar and the breadcrumbs (again not present on your page) stickySidebar - Is being sticky in your example. As your sidebar is longer than your view, it will scroll up and down else you would not be able to access the lower links. However being sticky, stops scrolling when it reaches the bottom while your content continues.

There is no option to include the breadcrumbs as a sticky component at this time.

I am confused by what you mean that the content would not hide under the navbar while scrolling? If the navbar is stuck to the top of the page, how would you view content beyond the view. Am I misunderstanding your intention?

macin commented 1 month ago

awh, my bad talking about content. I had a title in mind, but in this setup, that would be cumbersome, so I suggest we forget about the content. However the sidebar I think it would make sense that it does not scroll up at all. Would it make more sense?

macin commented 1 month ago

On a second thought, maybe the sidebar should scroll without moving the top? I think this is what I would prefer, but this is not major thing, if difficult/does not fit into your vision, then I can certainly live with this :) Although the breadcrums stickiness would be great :)

nomadjimbob commented 1 month ago

The sidebar will only scroll when 'sticky' if it is longer than the users window. If it did not scroll to reveal the lower links, the user would have no way to ever reach those links.

The sticky sidebar originally worked the way you are saying, however there was a heap of feedback that this design made it useless because of not having a way to access longer sidebars.

If this is something you would really want to see, I could add a 'super-sticky-sidebar' option for this?

macin commented 1 month ago

No, not necesseary, Thank you for offering that.I will rely on your experience

macin commented 1 month ago

Maybe as a different point of view, please take a look how it works on my current legacy template This ended up being the most usable way ... sidebar was independent of whole page scrolling. This worked for very large trees without a problem. 2024-06-06_11h24_39

That means that maybe I incorrectly defined the problem as "sticky". Better name would be "independent" sidebar.

nomadjimbob commented 1 week ago

Will update the code and docs as that is a better term for what the feature has grown to become. However, its a real low priority for me at this time.