Additional tests for `run-tests.yaml`

nomadkaraoke / python-audio-separator

Easy to use stem (e.g. instrumental/vocals) separation from CLI or as a python package, using a variety of amazing pre-trained models (primarily from UVR)

MIT License

514 stars 86 forks source link

Additional tests for `run-tests.yaml` #110

Closed Bebra777228 closed 2 months ago

Bebra777228 commented 2 months ago

Ubuntu and Windows started and completed successfully, but macOS failed.

As far as I understand, Ubuntu and macOS can work with Python versions such as 3.8, 3.9, 3.10, 3.11, and 3.12. However, in Windows, an error occurs when using Python versions below 3.10. I decided to install three versions of Python on each platform to avoid overloading Actions.

I think we can remove the test for macOS, but I'll leave that up to you :)

beveradb commented 2 months ago

Seems reasonable to me, thanks for contributing! I personally use macOS as my daily driver so it's actually the platform I care the most about working, I'll leave the macOS tests in 😅

beveradb commented 2 months ago

In case you're curious, I fixed the tests on macos by getting it to use a different (much lighter) model than the default one, which resolved the OOM in CI: https://github.com/nomadkaraoke/python-audio-separator/commit/8f58d140b97508bbd2bbd97a82924bc33afcf0e2#diff-910473b6c2470739b209e36399cf9c87b9c7953c6813071ae3c3d2404b924553R65