Further work

[sebwolf-de]

Thanks for your initial work! Based on our call here are some suggestions for improvement:

Use booleans instead of 0/1 integers for e.g.

• [ ] Plasticity

• [ ] Boundary conditions (also make the names more verbose)

• [ ] SurfaceOutput

• [ ] FaultOutputFlag

  Use a enum/String instead of integers for e.g.

• [ ] FL: Options: look into evaluate_friction_laws

• [ ] Method: Options: GP, elementwise

• [ ] OutputPointType: Options: 0: no output, 1: take GP's 2: 4 points per surface triangle, 3: output at certain pickpoints)

• [ ] printIntervalCriterion: Options: 1=iteration, 2=time

• [ ] SourceType: Options: nrf, fsrm

• [ ] meshgenerator: Options: look into the mesh reader. There should be PUML and netcdf (and maybe more)

• [ ] Format: Right now, I guess there are only HDF5 (6) and no output (10)

• [ ] printIntervalCriterion: # Criterion for index of printed info: 1=timesteps,2=time,3=timesteps+time

Think about the OutputMasks: Can we make the input more verbose:

• [ ] OutputMask: 1 1 1 0 1 1 1 1 1 0 0 # output 1/ yes, 0/ no - position: 1/ slip rate 2/ stress 3/ normal velocity 4/ in case of rate and state output friction and state variable 5/ background values

Think about nRecordPoints:

• [ ] I don't like to add the number of record points, it should be automatically be deduced from the file the coordinates. Maybe make this also a yaml file.... nRecordPoints: 12

[krenzland]

Regarding the enums, the easiest way is to accept strings and then convert it to the enum, like this

[krenzland]

The parameters are used here:

1. https://github.com/SeisSol/SeisSol/blob/master/src/Numerical_aux/typesdef.f90
2. https://github.com/SeisSol/SeisSol/blob/master/src/Initializer/dg_setup.f90

The first one defines all types used throughout the Fortran code, the second one initializes some stuff for Fortran. Don't look too closely at that, most of the settings are actually unused. The structs for equation/discretization/etc are actually used throughout the code.