Open LoisSotoLopez opened 3 months ago
Also, for people not wanting to fix whatever might make the check fail, there's an option ( :mage_man: that I will not name here) for git push
to skip pre-push hooks.
I've been thinking about this for a while and would avoid it, at least for now. I've read several online discussions on the pros and cons and found no compelling reasons to add pre-push hooks to the repo. As we are a little team of contributors, I would suggest that each one maintain its hooks, at least for the moment.
Forgetting about running the Rebar3 check alias can happen to anyone and explicitly add on the README that we should always do that before contributing... I would forget anyway. Having a pre-push hook feels fair enough to me and would help on keeping the commit history cleaner.