search

nomcopter / react-mosaic

A React tiling window manager
https://nomcopter.github.io/react-mosaic/
Other
4.39k stars 226 forks source link

Support bp 4 #183

Closed nomcopter closed 2 years ago

nomcopter commented 2 years ago

Fixes #161 Fixes #181

Changes proposed in this pull request:

Adds blueprintNamespace as an optional prop of Mosaic so that mosaic-blueprint-theme can work with Blueprint v4

casperOne commented 2 years ago

IIRC when I ran into this:

https://app.circleci.com/pipelines/github/nomcopter/react-mosaic/103/workflows/a9799cd0-0d25-449c-84ee-01ae1b69a014/jobs/195

I just removed the "Install Yarn" step from here

https://github.com/nomcopter/react-mosaic/blob/master/.circleci/config.yml#L17

As yarn is already included as per:

https://circleci.com/docs/2.0/yarn/#using-yarn-in-circleci

Note that you may be tempted to upgrade this image:

https://github.com/nomcopter/react-mosaic/blob/master/.circleci/config.yml#L12

To cimg/node, but I believe you have to set up authentication.