search

nomcopter / react-mosaic

A React tiling window manager
https://nomcopter.github.io/react-mosaic/
Other
4.39k stars 226 forks source link

Import lodash/kebabCase instead of lodash in OptionalBlueprint.tsx #207

Closed fvsch closed 1 year ago

fvsch commented 1 year ago

Fixes #206

Changes proposed in this pull request:

Reviewers should focus on:

Not 100% sure the import-blacklist tslint rule is wanted. Happy to remove that if we only want the fix in OptionalBlueprint.tsx.

Screenshot

n.a.

fvsch commented 1 year ago

With the added tslint rule but without the fix in OptionalBlueprint.tsx, running yarn run test:lint gives this error:

❯ yarn run test:lint
yarn run v1.22.19
$ tslint -c tslint.yml -p tsconfig.json -e test
/Volumes/Pieces/Code/fvsch/react-mosaic/src/util/OptionalBlueprint.tsx:4:16
ERROR: 4:16  import-blacklist  Importing this module is blacklisted. Try importing a submodule instead.
nomcopter commented 1 year ago

Amazing! Good catch and thanks for the fix + lint rule.