nomeata / gipeda

Git Performance Dashboard
MIT License
79 stars 26 forks source link

Documentation for settings.yaml #24

Closed christetreault closed 6 years ago

christetreault commented 9 years ago

Is there a list of valid fields in the settings.yaml file, and what they mean somewhere? I'm trying to set up a gipeda deployment for a project I'm working on, and I'm kind of at a loss as to how to write the settings.yaml file.

So far, I've been looking at the example file, but that's only going to get me so far. Maybe there's extra customizable settings that would make more sense for my project?

So far, I've found:

BenchSettings in https://github.com/nomeata/gipeda/blob/master/src/BenchmarkSettings.hs#L24 Settings in https://github.com/nomeata/gipeda/blob/master/src/BenchmarkSettings.hs#L85

Am I missing any?

christetreault commented 9 years ago

It seems to me that the format of the file is:

a header (Settings) followed by multiple BenchSettings.

For the Settings:

for the BenchSettings:

P.S. After we get this sorted, I can add this in the form of haddocks for Settings and BenchSettings (and maybe readSettings) if you like.

nomeata commented 9 years ago

Hmm, sorry for not documenting this very well. I hope the documentation will grow and improve as there are actually users besides me :-)

Let me explain the settings here for now, and maybe move it to a proper location (more likely README than the haddocs, as this is important for users, while the haddocks are useful for developers). later. If you want to contribute that, that’s of course most welcome!

The settings.yaml supports these keys:

A benchmark setting supports these keys:

christetreault commented 9 years ago

Excellent, thank you!

Yeah, I suppose the README would be the ideal place to put this stuff. I had been reading the code all morning, and just got "haddocks!" stuck in my head.

I'll leave this issue open for now, until the docs get updated or you get tired of looking at it.

christetreault commented 9 years ago

(I don't want to clutter up your bug tracker, so I'll ask the question here)

Might it be useful to add a BooleanNT to data NumberType?

Our test suite produces a .csv of the form [name],[text execution time],[test successful?], and we're currently just cutting off the success field in our log2csv. I think it might be useful to instead let the [test successful?] field be a separate benchmark.

I could just have that field be a small integer, and 0=false/1=true but I think it'd be cleaner to have a boolean. Additionally, it'd allow you to change how boolean values are represented in graphs and such if you cared to do such a thing in the future.

nomeata commented 9 years ago

Don't be shy opening new tickets, better than long tickets with unrelated discussions.

Your suggestion is quite reasonable, I might add it when I come to it. My only worry would be that it would not be clear what lessIsBetter should mean. Maybe it shouldn't be boolean but rather have good and bad as values.

christetreault commented 9 years ago

Very well, I've opened a ticket: https://github.com/nomeata/gipeda/issues/26