search

nomeata / incredible

The Incredible Proof Machine
MIT License
358 stars 36 forks source link

Fix unintended deselection of blocks after dragging #117

Closed yuxuanchiadm closed 4 years ago

yuxuanchiadm commented 4 years ago

Minor quality of life fix

yuxuanchiadm commented 4 years ago

LGTM😄

nomeata commented 4 years ago

Oh, wow, I haven’t touched this code in years. I asume you have tested it? :-]

yuxuanchiadm commented 4 years ago

yup tested locally

nomeata commented 4 years ago

:crossed_fingers:

yuxuanchiadm commented 4 years ago

Oops. Looks like travis build did not include contents in js-interface-wrapper.js into logic.js for some reason. GHCJS just ignored js-sources?

nomeata commented 4 years ago

Did you change the version of GHCJS or so? Maybe related to https://github.com/haskell/cabal/issues/5442?

yuxuanchiadm commented 4 years ago

No I didn't. But I just noticed we got different cabal-install version with last successful build from ppa.

New: Get:3 http://ppa.launchpad.net/hvr/ghc/ubuntu trusty/main amd64 cabal-install-head amd64 3.1+git20191103.2.129775a-6~14.04 [4,411 kB]

Old: Get:3 http://ppa.launchpad.net/hvr/ghc/ubuntu trusty/main amd64 cabal-install-head amd64 2.5+git20190112.1.6a24235-6~14.04 [4,314 kB]

nomeata commented 4 years ago

Maybe https://github.com/nomeata/incredible/pull/118 helps

yuxuanchiadm commented 4 years ago

🤞

nomeata commented 4 years ago

Nope, that did not help. Can you maybe debug this? I haven't touched this project in a while…

yuxuanchiadm commented 4 years ago

Sure. But looks like it didn't pushed to incredible-demo repo. Travis still doing it's job

nomeata commented 4 years ago

Oh, was I too impatient? Maybe it helped after all…

yuxuanchiadm commented 4 years ago

Yes. it works🎉

nomeata commented 4 years ago

Phew :-)

Thanks for your contrution!