search

nomeata / incredible

The Incredible Proof Machine
MIT License
358 stars 36 forks source link

Helper block edit dialogues open an all click events, even move and delete #132

Open yogo1212 opened 2 years ago

yogo1212 commented 2 years ago

when i delete a custom block, an editor pops up

nomeata commented 2 years ago

Hmm, I tried to reproduce it, but couldn’t. Can you give step-for-step instructions, or post a screen capture video?

michaelgwelch commented 2 years ago

I've seen this with "type annotation" helper block which is maybe what is being referred to.

https://user-images.githubusercontent.com/826112/183489962-9943ddea-40e1-4da2-872c-bf429a6fe48e.mp4

The editor pops up on a move or delete.

nomeata commented 2 years ago

Thanks! That clarifies things.

As you can see in your recording, it even happens when moving the block.

It looks like the on-click-handling, which opens the dialogue, started to act even when something else happened (moving, deletion). I wonder if this is due to a recent in one of the used libraries.

It doesn’t seem to be too disastrous, so I’ll have a look when I am touching the code anyways. But if someone else wants to give it a shot: It’s plain JavaScript, and I guess the bug is somewhere here: https://github.com/nomeata/incredible/tree/master/webui

michaelgwelch commented 2 years ago

As you can see in your recording, it even happens when moving the block.

Yeah, i mentioned that, but my comment was under the video and easily missed.

yogo1212 commented 2 years ago

oops! i only played with it a bit and found the bug - sorry for the confusion! and thanks, @michaelgwelch for adding the correction :-)