nomeata / incredible

The Incredible Proof Machine
MIT License
359 stars 36 forks source link

remove source ghcjs, the nixpkgs patch has been merged #143

Open makoConstruct opened 4 months ago

makoConstruct commented 4 months ago

in shell.nix there is

        # Can be dropped when nixpkgs includes
        # https://github.com/NixOS/nixpkgs/pull/177489/files
        # Keep synced with kaleidogen for better cache usage!
        ghcjs-base = super.ghcjs-base.overrideAttrs(d: {
          src = pkgs.fetchFromGitHub {
            owner = "ghcjs";
            repo = "ghcjs-base";
            rev = "fbaae59b05b020e91783df122249095e168df53f";
            sha256 = "sha256-x6eCAK1Hne0QkV3Loi9YpxbleNHU593E4AO8cbk2vUc=";
          };
        });

It seems like that time has come.

(Tragically, I only noticed this after spending 3 hours compiling ghcjs from source)

nomeata commented 4 months ago

Thanks! Have you tried this already?

makoConstruct commented 4 months ago

No, haven't gotten around to it

makoConstruct commented 3 months ago

Alas. I commented out the ghcjs base source part, now nix-shell errors with complaints about a missing aeson. I don't know what that is, but it's already being included in two different parts of the nix expression, so I'm at a complete loss.

configuring
configureFlags: --verbose --prefix=/nix/store/c4wf0qp6ca38bqnng5mi7hjgxc6j264s-ghcjs-base-0.2.0.3 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/a4zldvgdiijqf8b91y5afwnriv4wy54v-ghcjs-base-0.2.0.3-doc/share/doc/ghcjs-base-0.2.0.3 --with-gcc=gcc --package-db=/build/package.conf.d --ghc-options=-j16 +RTS -A64M -RTS --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --disable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --disable-library-stripping --disable-executable-stripping --ghcjs
Using Parsec parser
Configuring ghcjs-base-0.2.0.3...
Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.2.1.0 supports
'ghc' version < 8.8):
/nix/store/9ggwfydbk690zcl42i21l1vzg025d0hm-ghcjs-8.10.7/bin/ghcjs is is based
on GHC version 8.10.7
CallStack (from HasCallStack):
  $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-3.2.1.0:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-3.2.1.0:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.2.1.0:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.2.1.0:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.1.0:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.1.0:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing or private dependencies:
aeson >=0.8 && <1.6