nomeata / screen-message

Very simple tool to display some text as large as possible
54 stars 8 forks source link

Add user option to scale the text down #1

Open fleutot opened 6 years ago

nomeata commented 6 years ago

Hi, and thanks. This needs also documentation in the manpage: https://github.com/nomeata/screen-message/blob/master/sm.6

I usually do scaling by adding spaces before and after, which works intuitive, you can do it even after you have started it and does not need extra options (I like to avoid becoming sm a beast with an endless list options). Do you think this option is really needed?

nomeata commented 6 years ago

Also, the option parser might want to complain if the argument is not a valid floating point number; and I am not sure if allowing 0.0 is useful.

fleutot commented 6 years ago

Fine, I understand your point of view!

nomeata commented 6 years ago

Well, my point of view is not unchangeable :-). Maybe we’ll see if more users request this feature.

SolidTux commented 6 years ago

I think a scaling feature would be useful, but not really as a command line option. Maybe some shortcut like ctrl + and ctrl -?

fleutot commented 6 years ago

@SolidTux I was planning to use sm on a remote machine, so I couldn't use a shortcut solution.

fleutot commented 6 years ago

@nomeata 0.0 is not useful, but I did not want to set an arbitrary limit (decide for the user when a scaling factor is too small). If someone tries to use 0.0 and gets no text, it's on them.

SolidTux commented 6 years ago

Why don't you check for <= 0 instead of < 0?

nomeata commented 6 years ago

For --invert we also have a key command. So I agree: If this is implemented, then maybe we want both flags and keys. But if we want keys, we also need a key combination to reset it to zoom-to-fit. Which key combo is appropriate there?

SolidTux commented 6 years ago

What about ctrl+0? That works in Firefox and Chrome so it would be at least somehow familiar.

nomeata commented 6 years ago

Sounds good, it’s what I would expect as well.

fleutot commented 6 years ago

Reset to scaling 1.0, or to scaling argument on command line? I agree on <= 0.

nomeata commented 6 years ago

Reset to scaling 1.0, or to scaling argument on command line?

That’s a corner case… to command line, I’d say.