search

nomeata / screen-message

Very simple tool to display some text as large as possible
54 stars 8 forks source link

Make GitHub Actions ensure that screen-message builds fine + address compiler warnings #18

Closed hartwork closed 8 months ago

hartwork commented 8 months ago

Sits on top of #17 for a chance at a green CI.

nomeata commented 6 months ago

@hartwork, do you know why CI starts failing? https://github.com/nomeata/screen-message/actions/runs/7830396209/job/21364330099#step:5:12

hartwork commented 6 months ago

@hartwork, do you know why CI starts failing? https://github.com/nomeata/screen-message/actions/runs/7830396209/job/21364330099#step:5:12

@nomeata yes, thanks for asking! Clang has branched off to Clang 19 now and as a result that repository now serves Clang 19 while Clang 18 now has a repository dedicated to version 18. So the fix is to adjust the related matrix entry. I'll also drop Clang 17 from CI to save resources since — as of today — I do not see a strong point to keep it while we have Clang 18 (which is likely stricter). I'm happy to adjust pull request #22 as needed, but maybe you like it in its current form already :smiley:

nomeata commented 6 months ago

Thanks for the quick response!