search

nomego / Lazyman.bundle

Lazyman Plex Channel
105 stars 24 forks source link

Preferences #2 #21

Closed unclenoriega closed 6 years ago

unclenoriega commented 6 years ago

Looks like I forgot to push some changes the first time? It's not showing the changes from the other PR, but the differences are there if you browse the code, so I'm not sure if this is right. Let me know if there's something else I need to do.

nomego commented 6 years ago

Yes, the Preferences-file was missing. The previous PRs changes have to be included here as well since I had to revert them. Sync your fork - https://help.github.com/articles/syncing-a-fork/ Then rebase your preferences branch on the updated master. Then you can revert my revert to get your original PR back - git revert 010ad448105e8a665af3a902dd66bbd94c799a0c

Then push your branch and this PR should be updated. Go to https://github.com/nomego/Lazyman.bundle/pull/21/files to verify that all changes are present.

unclenoriega commented 6 years ago

The Plex Media Info shows multiple qualities for the recaps, but I disabled the setting for recaps anyway since it looks like the resolutions available are different for NHL and MLB. (Live streams are somewhat different, but they overlap better.)

Also, thanks for the git help!

ghost commented 6 years ago

I noticed that there's a place in init to specify the CDN. I know you're still sorting out this PR, but when everything gets synced up do you think you could add a preference for switching between CDNs? I'm happy to add it myself once this pull is complete, the only piece of information I would need is the abbreviation/code for Level3 (I'm clearly not familiar with the Lazyman API).

unclenoriega commented 6 years ago

@evilsparc Good idea. I've implemented it, and it seems to be working. I've pushed the changes for now, but I'll test more when there are some live games.

ghost commented 6 years ago

@unclenoriega Beautiful! I'll do what I can in the way of testing this as well and let you know if I come across any showstoppers.

unclenoriega commented 6 years ago

I think these commits address your concerns. I also reapplied the quality setting to recaps, now that missing resolutions are handled better.

nomego commented 6 years ago

Hmm also when saving prefs I get:

017-10-12 23:54:47,598 (70000a906000) :  DEBUG (runtime:717) - Handling request GET /:/plugins/com.plexapp.plugins.lazyman/prefs/set?show_scores=false
2017-10-12 23:54:47,601 (70000a906000) :  DEBUG (runtime:814) - Found route matching /:/plugins/com.plexapp.plugins.lazyman/prefs/set
2017-10-12 23:54:47,602 (70000a906000) :  DEBUG (preferences:198) - Saved the user preferences
2017-10-12 23:54:47,602 (70000a906000) :  CRITICAL (sandbox:298) - Function named 'ValidatePrefs' couldn't be found in the current environment
nomego commented 6 years ago

Another thing is that recaps and extended highlights and condensed games for MLB all get titled "Recap" now, they should at least have their different types?

unclenoriega commented 6 years ago

Definitely I'll fix the titles. Not sure why I didn't realize that.