search

nomego / Lazyman.bundle

Lazyman Plex Channel
106 stars 24 forks source link

Fix old dates and upgrade MLB date and game list #63

Closed csmith1210 closed 5 years ago

csmith1210 commented 5 years ago

Okay to start off, the first commit fixes #62. What was happening was that the plugin would get the NHL/MLB m3u8, but it would be expired and produce a 404 error. Now I implemented a check in __init__.py and if it catches an error then a "Game feed expired." item appears. Also the recap video was erroring out for iOS because plex was sending an extra argument which the browser would ignore, so I added a **kwargs expectation for that. The result is now this: TODO: IMAGE of NHL and MLB Date that shows game expired

image

Second another bug fix, I noticed that if you went to an MLB day, then an NHL day the GAME_CACHE would remember the MLB games and include them in the description for the NHL day. It was the same for the reversed. I hope that makes sense. The fix was to change the GAME_CACHE list to a dictionary that had two keys 'mlb' and 'nhl' and make the GAME_CACHE references store the dates and games based on sport. This partially relates to:

Third, I wanted to make the MLB days and games display just like the NHL so they don't look as abandoned. So the list of dates now displays like so:

image

And the actual dates displays like so:

image

I think this really ups the quality. If this is too much for you, I can roll back the changes to just fix the 404, iOS, and cache errors.

csmith1210 commented 5 years ago

Just a bump on this.. The latest commit fixes an issue I had today and discovered the iOS app started sending a new argument to any of the main functions like MainMenu, Dates, Feeds, etc. Just added a catch all for those arguments that we don't care about.

nomego commented 5 years ago

Sorry for late response, looks great! Thanks for the contribution!