nomensa
commented
12 years ago Thanks Dan, and really good to speak to you earlier. Your help with this is really appreciated. If you feel up to looking at a longer term solution when you have time, that'd be great. Beers on us next time you pop over of a Friday evening.L.
-----Original Message----- From: fatboystring [mailto:reply@reply.github.com] Sent: 09 May 2012 23:08 To: github Subject: [Accessible-Media-Player] Accessible Media Player - Destroy method (#8)
Hi Guys,
I was speaking to Hans Hillen the other night. He had come up against an issue that warranted the inclusion of a destroy() method on the Media Player. I have added this into the player and tightened up a few of the timer methods. This seems to solve the issue for the time being. However, I think there is a more elegant solution to the problem. I do not have the time to do this right now but will get the chance in a week or so. It's up to you if you want to merge this pull request, or leave it for the time being.
Feel free to comment if you so desire :)
You can merge this Pull Request by running:
git pull https://github.com/fatboystring/Accessible-Media-Player master
Or you can view, comment on it, or merge it online at:
https://github.com/nomensa/Accessible-Media-Player/pull/8
-- Commit Summary --
- Added destroy method to player. Allows us to destroy the player. Also provides a hook for clearing up any references to the 3rd party player instance. Added check to ensure that slider timeout is not set more than once. Updated PlayerDaemon to always override references to a player with another of the same id. Also updated removePlayer method on playerdaemon. Now calls destroy() on the player before removing it from the PlayerDaemon
- Added destroyPlayerInstance method for clearing up references to the jwplayer
- Minified versions of the previously committed files
-- File Changes --
M core/javascript/jquery.player.js (38) M core/javascript/jquery.player.min.js (14) M custom/javascript/config/jwplayer-5/jw-player.config.js (5) M custom/javascript/config/jwplayer-5/jw-player.config.min.js (3)
-- Patch Links --
https://github.com/nomensa/Accessible-Media-Player/pull/8.patch https://github.com/nomensa/Accessible-Media-Player/pull/8.diff
Reply to this email directly or view it on GitHub: https://github.com/nomensa/Accessible-Media-Player/pull/8
Hi Guys,
I was speaking to Hans Hillen the other night. He had come up against an issue that warranted the inclusion of a destroy() method on the Media Player. I have added this into the player and tightened up a few of the timer methods. This seems to solve the issue for the time being. However, I think there is a more elegant solution to the problem. I do not have the time to do this right now but will get the chance in a week or so. It's up to you if you want to merge this pull request, or leave it for the time being.
Feel free to comment if you so desire :)