Destroy method needs to remove data

nomensa / jquery.hide-show

jQuery plugin for inserting buttons/links to hide and show sections of content

http://nomensa.github.io/jquery.hide-show

MIT License

6 stars 6 forks source link

Open kemiga opened 9 years ago

kemiga commented 9 years ago

Currently have to add: "target.removeData('plugin_hideShow')" in order to completely destroy the plugin data.

lawlesscreation commented 9 years ago

When destorying the plugin, we may need to using .off to unbind the trigger when using existing elements as well as removeData.

lawlesscreation commented 9 years ago

Pull request raised #19

We cannot add removeData('plugin_hideShow') as it means fundermentally changing the plugin and how it initialised/rebuild

anevins12 commented 8 years ago

@lawlesscreation Would this be a won't fix issue?

anevins12 commented 8 years ago

As we're removing the rebuild function, I'm going to continue to remove the data on destroy as Kate raised

anevins12 commented 8 years ago