search

nomic-ai / deepscatter

Zoomable, animated scatterplots in the browser that scales over a billion points
Other
1k stars 57 forks source link

npm run build fails because of typescript errors #103

Open preussi opened 7 months ago

preussi commented 7 months ago

I cannot build the module because the third compilation step fails due to errors in files:

Found 141 errors in 14 files.

Errors Files 1 node_modules/apache-arrow/util/buffer.d.ts:8 16 src/Aesthetic.ts:68 7 src/AestheticSet.ts:3 21 src/ColorAesthetic.ts:1 3 src/Dataset.ts:3 1 src/Image_Tile.ts:1 35 src/deepscatter.ts:3 12 src/interaction.ts:10 13 src/label_rendering.ts:46 17 src/regl_rendering.ts:8 3 src/rendering.ts:228 8 src/selection.ts:74 1 src/tile.ts:623 3 src/util.ts:16

Am I doing something wrong or is this associated with the version of typescript? I checked my version and it is 4.7.4.

vzsolt1981 commented 4 months ago

As of today, by following the instructions, I'm getting the same build error as @preussi.

Any update on this?

cceyda commented 1 month ago

same here so I just used the version from cdn although it isn't the latest: import Scatterplot from 'https://cdn.jsdelivr.net/npm/deepscatter@2.15.2/+esm'

cceyda commented 1 month ago

I would really like a solution to the build problems though because I want to use arrow_table but it is giving Vector constructor expects an Array of Data instances error when run with 2.15.2 and only works from source

cceyda commented 1 month ago

Ok I was able to build using the commented out vite.config instead. (comment out the code before that line and uncomment the commented code) https://github.com/nomic-ai/deepscatter/blob/901a038dc731995c15f21c4645ab9556f82517e0/vite.config.cjs#L20

kungfooman commented 1 day ago

Suggestion: Convert to pure JavaScript / ESM with a jsconfig including the {checkJs: true} option and don't waste time on such TS errors anymore... you will be able to load the library via import map - completely build free, allowing quick PR testing aswell.