search

nomic-ai / gpt4all-chat

gpt4all-j chat
Other
1.27k stars 155 forks source link

Add platform-specific includes #114

Closed kuvaus closed 1 year ago

kuvaus commented 1 year ago

On windows we need to include #include and on unix/mac we need #include . Fixes issue #113

manyoso commented 1 year ago

This will mess up with mingw on windows won't it? BTW, who is this in discord? ;)

kuvaus commented 1 year ago

Yes it will.

I agree its better to use MinGW instead. That way you can use all functions straight out of the box. Found out that with you have to also use #define NOMINMAX to get some functions working.

I thought of this because GitHub CI/CD Actions with CMake template does not come with MinGW unless you setup it with something like:

    - name: Set up MSYS2
      uses: msys2/setup-msys2@v2
      with:
        install: mingw-w64-x86_64-toolchain
        path-type: inherit

Its probably better to discard the changes, use MinGW and close this issue.