Closed Tim453 closed 1 month ago
Please sign the commit using 'git commit -s --amend' which will add a sign off string to the commit message. You'll have to force push to overwrite the commit here. Also, can you please email me to confirm maintaining this? Thank you!!!
I realized that the gpt4all-chat/flatpak-manifest/io.gpt4all.gpt4all.yml
was removed in this PR. Is there any reason for this?
My point is if maintainers are separating themselves from the Flatpak (imho extremely bad idea), then removal of yaml file is justified, but it begs the question about the keeping the rest of the folder including the XML and the PNG files.
@manyoso I would like to reiterate my opinion that having third-party Flatpak is not a good idea. @Tim453 can become an official maintainer, the yaml file and the rest can atay in the repo, and a CI can build the Flatpak for every release. This way it would be cohesive and instead of providing deb file for Ubuntu (and Debian), they can cover a much wider range of Linux distros and almost no cost. Tim would also get the acknowledgment for his hard work.
To publish a build on Flathub the manifest needs to be in the Flathub repository. So I thought it made sense to remove it from here, otherwise two copies of it would have to be maintained. I left the metadata in this repository so the maintainers can decide how the app appears in the store.
But you are right maybe there are better solutions, that integrate directly into the CI of this project.
It is possible to edit the CI of this project in the .circleci directory. We could add a 'build flatpak' just like we have a build for the current online/offline installers. Unfortunately, I have no time to do that just now so if one of you guys wishes to do that it is good by me.
@mmahmoudian I'm not here for the rest of the discussion, just wanted to clarify something:
... This way it would be cohesive and instead of providing deb file for Ubuntu (and Debian), they can cover a much wider range of Linux distros and almost no cost. ...
The official installer is not just for Ubuntu and Debian based systems. It's built on Ubuntu, but packages most of its dependencies itself, so it works on many more distros. I think all there needs to be are matching C/C++ runtimes which are not too old. It doesn't use the system's package manager, either. It's made with Qt's installer framework.
That said, I do like that there's a Flatpak available nowadays.
@cosmic-snow you are almost right about the gcc part, but not quite. Today I spent about 7 hours trying to compile it on my machine. The issue was that I use Guix on Arch and I had to untangle all the gcc and gcc toolkit that Guix being with itself to a foreign distro. I acknowledge that this is a bit niche case, but for me in my messed up setup took hours to realize why ld cannot link certain things, and perhaps for a non developer user, running flatpak install ...
is much easier and straightforward, and specially when they can use Flatseal to adjust some of the permissions (e.g networking)
@Tim453 I have not worked with CircleCI, but if you are up for it I can also pitch it and help if needed
Today I spent about 7 hours trying to compile it on my machine. The issue was that I use Guix on Arch and I had to untangle all the gcc and gcc toolkit that Guix being with itself to a foreign distro. ...
I only wanted to mention that the installer isn't just specifically for Ubuntu (and related). But looks like you know your way around if you tried that. I'd even wager you're the first trying that particular combination. 😅
@mmahmoudian that would be great. It could be integrated into the CI, as in this project.
@Tim453 as far as I can see, the Heroic Games Launcher is not based on circle CI. I'm involved with a couple of projects and in one of them which we build flatpak using Github Actions:
@cosmic-snow for this purpose, should we stick to circle CI or can we use GitHub Actions too?
for this purpose, should we stick to circle CI or can we use GitHub Actions too?
I'm not really involved in that so I can't tell you, sorry.
Describe your changes
Currently the description on flathub is a little bit outdated this PR tries to change it
Issue ticket number and link
698
Checklist before requesting a review