nomic-ai / gpt4all

GPT4All: Run Local LLMs on Any Device. Open-source and available for commercial use.
https://nomic.ai/gpt4all
MIT License
69.01k stars 7.57k forks source link

Bring back the quoted excerpts from local docs instead of merely listing the files #2736

Open Seedmanc opened 1 month ago

Seedmanc commented 1 month ago

Why would you ruin it in redesign? Lack of understanding what exactly was found by the RAG search before it got sent as context to LLM makes it impossible to debug and tune the prompts. You're forcing us to deal with two unknowns here, the vector search for excerpts in addition to the LLM's understanding of the context and prompt. Why does every redesign ever makes things worse and removes existing features? It's not just here, it's everywhere in software and web.

This is a bug, not a feature request, since clearly it's an introduced regression in update, and not something that has to be created from scratch. You just oversimplified the UI, losing what's important.

AndriyMulyar commented 1 month ago

its not a regression, it was by design. feel free to open a pull request with code that proposes a way of incorporating this information into the UI in a nice way!

Seedmanc commented 1 month ago

it's a sabotage if new UI's bells and whistles are accepted at the cost of actual functionality

SINAPSA-IC commented 1 month ago

Yes, it is a regression, and a major one at that. Excluding the precise place where info was drawn from tramples upon the very functionality that both the "Sources" button where pages could very well be listed (as in prior versions - no new code, that is) and the textboxes in "Settings", with the number of snippets from LocalDocs and their length pretend to be offering to the user, as useful functionality, textboxes that as of v3.0.1 are mere UI artifacts (even worse if they are callable artifacts within the code, too) from v2.8.0 and prior, where they indeed have had a meaning and role.

In this case, either this functionality is properly REimplemented, or excluded from the program, as in this form is a bit more than a mockery to the users (who want to use something) and developers (who want to Develop something, oh wait, they already have - just have to write the pages, below the file's title).

Moreover, telling a user who is asking for an improvement or a change to open a PR with their own code reeks of quick dismissal and scorn, because not all users know how to code (God forbid they put their mind to it and make a better program), and anyway writing a program is not something that the users should do,

And yes - sabotaging one's own good work does not stand well with future prospects for any program, aka "strategy", even less so in a culture and domain where competition is at cutthroat level and there's no time to waste.

cosmic-snow commented 1 month ago

Have you tried hovering over the bottom right corner of one of the sources?

brankoradovanovic-mcom commented 1 month ago

Have you tried hovering over the bottom right corner of one of the sources?

Oof... I've seen that hoverbox flash once, by accident, but I couldn't reproduce it, because it never occurred to me I needed to hover over a particular area that was not marked in any way...

SINAPSA-IC commented 1 month ago

The bottom-right corner? Oh that visibly marked area in such an obvious way? OK... stoopid me, how could I not have seen it? imagine it, suspect it, hope for it being there, even. Any more Easter eggs that the user Has To discover by themselves?

Anyway, the popup message with excerpts disppears right after moving the pointer outside the so-called area (fwiw, it may be a circle w/ diameter 1px), so Nothing can be done with that excerpt but capturing it as an image with PrintScreen, oh that 1990s feeling.

A poor design decision that diminishes the functionality (the user will not use an invisible functionality, meaning that that functionality does not exist at all - it is Designer-eyes-only, or on a need-to-know basis), that's what it's called, but it's easier to place the blame on the user for not being able to fathom what the Designer had in mind at that moment, instead of reasoning it out at/with the very source of the Issue like give it another color than the background ffs, there's that thing called testing. that is if those color schemes that also hide the scrollbars can be touched for Improvement or another coding tool must be brought into the mix for showing that puny sign in the corner.

If the UI designer is not able or willing to put an interface to the functionality that the coder implemented, then they both may as well call it quits. If they cannot respect each other's work and their own work, no way for them respecting the user, which by the comments here is all too visible. This you learn before starting to make programs for Others and not for yourself. Do Not hold the users answerable for the mess they encounter while working with /your program and for not knowing how to work with it, ok? tks!

img30_ui15

Seedmanc commented 1 month ago

Well, I'm glad the functionality isn't entirely gone, but this is the most unexpected way to keep it. Besides, that makes it impossible to copy, and in case with a large Chunks X Size setting, not all of them even fit on screen (only 9x1024 do for me). Most of the confusion in this thread could've been avoided if the first response pointed out the hover trick, indeed.

cosmic-snow commented 1 month ago

Well, I did not make any of the decisions with how that is presented now, I was just trying to help.

I have to say however, it would do you well to phrase your comments in a more constructive/less aggressive way, because this isn't very helpful. (I should not have to defend myself anyway and I did not read all of it, just fyi.)

vap0rtranz commented 3 days ago

How about a simple icon added the lower right of the Source button? To make the pop-up visible in the UI.