nomic-ai / gpt4all

GPT4All: Run Local LLMs on Any Device. Open-source and available for commercial use.
https://nomic.ai/gpt4all
MIT License
70.77k stars 7.71k forks source link

Interruptable scans by timer is just broken from what I can tell. #3089

Closed manyoso closed 1 month ago

manyoso commented 1 month ago

The change to interrupt by time is just flat out broken. The behavior breaks completely with zero msecs and will break on different systems depending upon CPU speed.

The behavior does resume on the previous document if it was interrupted and in the correct place.

shanselman commented 1 month ago

THIS feels very YES, intuitively. This makes a lot of sense and matches what I was seeing...I also felt like the indexing/embedding were chasing each other, and depending on GPU (mine is a 4080 Super, so FAST) and CPU, you could get into a deadlock if the GPU got caught up to.