Classes derived from AtlasBaseClass should be initializable using an AtlasViewer. Because AtlasUser overrode the base constructor, we lost the ability to do this. This re-adds the ability to construct an AtlasUser from an AtlasViewer, while preserving the legacy object based initialization.
:rocket:
This description was created by Ellipsis for commit 1dc5c890bae80f6bccf3ef4451a6aa024482d272
Summary:
This PR updates the AtlasUser constructor to accept an AtlasViewer instance, restoring functionality and adding corresponding tests.
Key points:
Updated src/user.ts to modify AtlasUser constructor to accept AtlasViewer.
Preserved legacy initialization using ViewMakerArgs.
Added test in tests/user.test.js to verify AtlasUser initialization with AtlasViewer.
Classes derived from AtlasBaseClass should be initializable using an AtlasViewer. Because AtlasUser overrode the base constructor, we lost the ability to do this. This re-adds the ability to construct an AtlasUser from an AtlasViewer, while preserving the legacy object based initialization.
Summary:
This PR updates the
AtlasUser
constructor to accept anAtlasViewer
instance, restoring functionality and adding corresponding tests.Key points:
src/user.ts
to modifyAtlasUser
constructor to acceptAtlasViewer
.ViewMakerArgs
.tests/user.test.js
to verifyAtlasUser
initialization withAtlasViewer
.Generated with :heart: by ellipsis.dev