search

nomiddleman / nomiddleman-woocommerce

WooCommerce cryptocurrency payment gateway focused on admin empowerment
https://nomiddlemancrypto.io
GNU General Public License v3.0
42 stars 38 forks source link

Add Support for Cardano (ADA) Shelley Addresses #21

Open andrewbrooke opened 4 years ago

andrewbrooke commented 4 years ago

I've been tinkering around with the code to try to get it to work for the upgraded Cardano Shelley address format.

I was able to get the settings page to accept a new address, like: addr1qxpfffuj3zkp5g7ct6h4va89caxx9ayq2gvkyfvww48sdn7nudck0fzve4346yytz3wpwv9yhlxt7jwuc7ytwx2vfkyqmkc5xa (See https://input-output-hk.github.io/cardano-addresses/haddock/cardano-addresses-1.0.0/src/Cardano.Address.Style.Shelley.html)

After configuring that I was able to create an order and send the payment to the address from my wallet, but the order stays stuck in the "On Hold" status.

I suspect there may be another change that introduces incompatibility somewhere. Messing around with getting logs working now, any advice would be appreciated!

If I'm able to resolve this I'll fork and submit a PR, cheers :)

andrewbrooke commented 4 years ago

Got things working with a Shelley address in this commit: https://github.com/andrewbrooke/nomiddleman-woocommerce/commit/349f72353b85243fef5914880ea57a2fb646344a