search

nominolo / atto-lisp

Efficient parsing and encoding of Lisp expressions for Haskell.
Other
24 stars 16 forks source link

convert from Number to Scientific #27

Open tyehle opened 4 years ago

tyehle commented 4 years ago

Converts the Number variant to use the scientific package instead of the attoparsec Number. I tried to not touch anything else :)

nominolo commented 4 years ago

Hi, thanks. Can you explain the motivation for the change?

tyehle commented 4 years ago

The use of Numeric generates depreciation warnings. From the docs it looks like you were planning on making the switch to Scientific eventually. Sorry if you would have preferred an issue before a pr!

On Sun, Feb 16, 2020 at 12:19 PM Thomas Schilling notifications@github.com wrote:

Hi, thanks. Can you explain the motivation for the change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nominolo/atto-lisp/pull/27?email_source=notifications&email_token=ABDJJ4W2A766L4M6ZWIUPVDRDFYSFA5CNFSM4KU5LTNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4MY3I#issuecomment-586730605, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDJJ4TOPPSJRNCWEVXKNJLRDFYSFANCNFSM4KU5LTNA .

tyehle commented 4 years ago

@nominolo Got any thoughts about if this is something you'd be interested in merging?