Refactor validation functions to use Either instead of Validated

nomisRev / ktor-arrow-example

Real World implementation - "The mother of all demo apps". Written in Kotlin, with Ktor, Arrow, SqlDelight, KotlinX Serialization, etc.

Apache License 2.0

271 stars 34 forks source link

Refactor validation functions to use Either instead of Validated #177

Closed Alfhir closed 1 year ago

Alfhir commented 1 year ago

Hi @nomisRev,

I'd like to learn a bit about OSS etiquette while doing this. So after I pushed changes, should I

Do nothing (will you get notified?) or
Write a comment?

nomisRev commented 1 year ago

Hey @Alfhir,

Do nothing (will you get notified?) or

I didn't get notified you pushed any changes 🤔 Even though I am subscribed to the PR. I think leaving a friendly reminder comment is never bad ☺️

Alfhir commented 1 year ago

These changes look perfect to me @Alfhir! Thank you 🙌 🥳

Thank you for providing the opportunity. It was great fun and if I can, I might do a few more of this to get to know Ktor better.

Have a great day

nomisRev commented 1 year ago

Sure, feel free to comment on any issue and I'll assign you. And again, no pressure if you're short on time. I'd be more than happy to guide, and help outside of hacktoberfest too 😉