Closed rm-you closed 2 years ago
Hey buddy, I think it's awesome that you are adding on this functionality! I am about to archive this repository though. I am not sure the best way to handle this though. I would be interested in transferring this if it is something you would like to upkeep.
I have 0 time to work on this and I don't play eq99 anymore which was my main driving force for creation.
Yeah, I'd be willing to take over upkeep on at least the 0.5.x (master) branch. So, you're dropping the new dev branch as well? :( I guess you could transfer it, though if you want to retain repo ownership that's cool too, maybe you could just add me as a maintainer/admin? I honestly wish you were still planning to be around, would love some code reviews, especially since you know this codebase a lot better than I do. :P
Ok, rebased all of this onto the dev branch. Looks really good! Some of it (opacity, clickthrough, spell/zone fixes, flush-frame) obviously wasn't even necessary to carry over since it was essentially already done. Quite a bit of duplicated work I guess, my fault for not figuring out the dev branch changes earlier. T_T Really looking forward to getting a release out using that -- might be worth putting out a demo release even just as it is, and gather some feedback and make incremental changes. If you're up for it, I guess transferring the repo over would be good, or at least adding me as a maintainer. I've found another developer who is working on some patches as well (or, I guess they found me) and hopefully we can get a real code-review pipeline going. :)
Hey!
Sorry. I am so busy, I barely get time to check my email n all that. I am going to add you as a maintainer and everything right now. Then we can figure out the transfer later -- that is not something I have ever done before and I don't really have the time to look into it right now.
Since this is not an organization repo, I have added you as a collaborator. Let me know when you wanna do the transfer -- I am not sure how the landing page on my user account will look if I transfer to you or if I need to do some sort of forwarding messaging to forward everything to you.
Please let me know.
Thanks! Tristan
On Sun, Apr 25, 2021 at 2:54 AM Adam Harwell @.***> wrote:
Ok, rebased all of this onto the dev branch. Looks really good! Some of it (opacity, clickthrough, spell/zone fixes, flush-frame) obviously wasn't even necessary to carry over since it was essentially already done. Quite a bit of duplicated work I guess, my fault for not figuring out the dev branch changes earlier. T_T Really looking forward to getting a release out using that -- might be worth putting out a demo release even just as it is, and gather some feedback and make incremental changes. If you're up for it, I guess transferring the repo over would be good, or at least adding me as a maintainer. I've found another developer who is working on some patches as well (or, I guess they found me) and hopefully we can get a real code-review pipeline going. :)
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nomns/nparse/pull/36#issuecomment-826277335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHDRJLDDEUOT572HAR5MBLTKPDEJANCNFSM42V2YKWA .
No rush, this should be fine for now. I'm still not sure if I want to land all of this work on 0.5.x or just move forward with the dev-branch, will mull it over for a bit. Thanks!
@rm-you (Toald), I'm willing to help with any future coding. I too took the master/main branch and added my own fixes/improvements. Now I'm perusing both nomns 'dev' branch as well as your fork to see if I fixed/improved anything you both haven't already coded.
@mametester I'm curious what kind of stuff you did! I don't see any repos on your account, did you fork it there or just have that work locally? Sorry I didn't see this until now, I also took a bit of a hiatus but am sorta-kinda back. :) Would love to have more eyes on changes, and some code reviews.
Update Notes
If you are updating an old installation, please extract the entire zip-file. Due to map-file, spell-file, and other data additions, extracting just
nparse.exe
is not enough to apply all of the changes.Bugfixes / Minor Tweaks
/tell toggle_maps
and/tell toggle_spells
. The new Discord overlay window also works with/tell toggle_discord
./who
and it should auto-load the correct zone, if for some reason your zone was not correctly detected.New Feature: Location Sharing
Your location can now be shared with other users running this version of nParse or newer. Simply enable the feature in the Sharing settings page, and your location will be broadcast to other users with the same
group key
(or share with a Discord channel, but this requires configuring the Discord overlay). Think of it like a password for your guild or group, so only people given access can see your location.Deaths are also recorded and shared, based on your last location before you died. Remember to
/loc
often! I recommend binding a loc macro to a movement key.There is a default sharing server, but if you would prefer to run your own, the server code is included as
location_server.py
.New Feature: Custom Path Recording
Custom path recording is now available (though consider it "beta"). Your feedback is appreciated!
To use it:
Custom Pathing
->Start Recording
./loc
will draw part of a new path on the map.Custom Pathing
->Stop Recording
to finish recording a path.Alternatively, you can type
/tell start_recording_PATHNAME
to begin and/tell stop_recording
to end recording.PATHNAME
does not support spaces, but any underscores will be replaced with spaces automatically.Custom path files are created in
data/maps/map_files/recordings/
and you can share these files with others, they just need to put them in theirrecordings/
directory and ensure they are using at least this version of nParse. It's also possible to manually edit these files if you want to clean up the paths after initial recording. The format is as follows: Lines:L x1, y1, z1, x2, y2, z2, R, G, B
Points:P x, y, z, r, g, b, size, text
New Feature: Discord Overlay Window
Now you can see your Discord voice channel overlay as an nParse window. You may need to authorize Discord StreamKit the first time you configure the overlay. Configuration is done via the ⚙️ icon on the nParse Discord window, or from the system tray icon.
/tell toggle_discord
.