nomns / nparse

Nomns' Parser for Project1999
GNU General Public License v3.0
43 stars 23 forks source link

I'm trying to understand why many spell names have duplicate entries in spells_us.txt #54

Open eddyystop opened 1 year ago

eddyystop commented 1 year ago

The cleric Fortitude spell was not resulting in a spell timer bar. I found there were 2 entries for Fortitude in spells_us.txt. The first entry has the right casting time, the second entry has 0. The way the code works, the second entry will be used and insta-cast spells are not displayed.

I changed the spell name of the second entry so the first entry is used, and I now get my spell timer bar.

I'm trying to understand the situation. There are many such duplicate names, almost all after line 1,000. Have spells changed with expansions and the new defns added to the end of the file? For P99, can I just delete all lines 1,000+ or do I have to change duplicate spell names one by one?

Very useful app BTW.

rm-you commented 3 months ago

Yes, the expansions are part of it. You can see at the very end of the line that some spells will say which era they apply to. If there's a specific spell (like Fortitude) that is parsing incorrectly, I can take a look at fixing it which is really just done by changing the name like you did. When I have a minute I'll check this one to verify it's broken and fix it globally. For now I would not recommend truncating the file.