nomns / nparse

Nomns' Parser for Project1999
GNU General Public License v3.0
43 stars 23 forks source link

Read spells_us.txt from game directory #55

Open That-one-Joe opened 1 year ago

That-one-Joe commented 1 year ago

Reading the spells_us.txt from the game directory would mean that the correct timings would be used automatically. I do not see any advantage of this file being in this project; it can possibly only use wrong timings which led me to create this issue - but maybe I am missing something why it was done this way.

https://github.com/nomns/nparse/blob/master/parsers/spells.py#L478 is the location for the change.

I propose changing eq_log_dir in the config to eq_dir generally, automatically appending Logs for the log reading and using this in spells.py for reading spells_us.txt.

rm-you commented 3 months ago

There are a lot of custom changes that have been made to that file to actually make things work correctly in-era and with certain features. It would just exhibit many other issues if this were done. Out of curiosity, are you on P99, TLP, or some other server? @That-one-Joe