nomns / nparse

Nomns' Parser for Project1999
GNU General Public License v3.0
43 stars 22 forks source link

Request #6

Closed kupoback closed 6 years ago

kupoback commented 6 years ago

Great work, a simple request is an always on top option if possible

nomns commented 6 years ago

You want to turn it off? Is it not working for you?

Are you running source/exe? What OS?

kupoback commented 6 years ago

No, when I am running it on Windows 10, using WinEQ, it is treated as a normal window, where-in if an application that takes up more real estate or is windowed full screen (like a browser), the application hides behind it.

I could not find the option to make it always on top. I followed your wiki after downloading it last night, the latest source version.

nomns commented 6 years ago

There is no option to have it always on top. It's on top by default (it is on my windows 10 with WinEQ box). The screenshots I have uploaded show it on top while I am playing windowed mode. I don't think I can make it go over a full screen mode game.

If you click the ☷ twice, does it fix itself? I have had a couple issues which I do have written down to look into where the odd time, the spells window will be ontop but the maps won't be (even tho they are both basically setup the same). Click the ☷ twice has fixed it (toggling the window frame on then off again).

kupoback commented 6 years ago

Oh, I am not asking for it to go full screen, i'm saying that when I use it, either double clicking the icon you mentioned twice, or otherwise, it is not always on top.

nomns commented 6 years ago

Do other on top applications work for you?

kupoback commented 6 years ago

Yes, I was using another map tool from the forums, but stopped as I didn't like the layout of it. Yours is much more ascetically pleasing. However that programs always on top worked.

nomns commented 6 years ago

This is probably a Qt issue. I'll take a look into this, but this is weird behavior I think. It sounds like we both use the same OS: mine works and yours doesn't (no one else has said anything either way, so I was thinking it was working).

My exe isn't digitally signed. I am hoping its not a security thing with Windows for the binary . I will add an on top icon in the next couple releases so you can specifically target that window flag and Ill put every thing I can find in that to try and force the behavior.

kupoback commented 6 years ago

Thank you, if you want I am very happy to be a tester for you. Like I said, I really like the application methods you have here and they look fantastic with the map styles being from EQ instead of EQAtlas.

You've done a great job!

nomns commented 6 years ago

Thanks dude! This feature (stay on top) is one of the most important things to me about my program. If it doesn't work, why bother using it? I wouldn't. I got two monitors, but then where am I going to play media? :)

That other program I think is done using C# which plays with windows much nicer than Qt. I like cross-platform solutions and I guess these types of things are the cost.

I won't have a new release out this weekend, but I am hoping to get this in the next release. (fingers crossed next weekend or before).

I'll close this as soon as the new release is out with some alternate enforcement for on topness.

kupoback commented 6 years ago

Sounds fantastic, keep up the good work, I'll be monitoring it and inform you of any issues! As a php developer learning python, I love looking at your source code and seeing what you're doing!

nomns commented 6 years ago

Oh sweet, you got python 3+ installed?

pip install pyqt5
pip install pyyaml
git clone https://github.com/nomns/nparse.git 
cd nparse
python nparse.py

Does on top work if you run it from source rather than binary?

kupoback commented 6 years ago

I have left my house for work, but I will run this tonight when I get home and see if it works running in python

kupoback commented 6 years ago

@nomns Running the script above, the map and spells are on top of my window!

Desktop Screenshot

nomns commented 6 years ago

download

This may be a windows security issue because I don't digitally sign my exe. I'll try to look into this before my next release.

Also, I think I'll start keeping my current git repository the release and create a development branch to work on.

Glad it's working for you!

kupoback commented 6 years ago

Yeahhh no idea, but i think i will execute via script. it worked great, but will be on the lookout for the next release.

nomns commented 6 years ago

Did you ever try running the exe as administrator?

kupoback commented 6 years ago

Yes, and to no avail.

kupoback commented 6 years ago

It could just be my computer in the end of it all. The script works for me as an alternative.

nomns commented 6 years ago

Damn, that would have been too easy. hah. Ok, I'm gonna go ahead and close this out. I am very happy its up and working for you! I'll try keep the master git runnable (if its ever broken you can get the source from the release page.). Let's see if anyone else complains!

nomns commented 6 years ago

! Also, since you are a web dev, you can always customize the spell window with the css in data/ui/_.css

Most of the spell window is done with css. The gradients are a weird qt css thing.

kupoback commented 6 years ago

Oh neat! I'll deft play around with it!

kupoback commented 6 years ago

@nomns Just wanted to pop in. Last night, I had WinEQ up and open. Was in LS running to Sol B. Found out I'd be pulling, so I typed in the script to get the application going. It would not sit on top of the window.

kupoback commented 6 years ago

Weird, even if i start the script before WinEQ it still does not stay on top.

nomns commented 6 years ago

But it worked the other day?

nomns commented 6 years ago

Im looking into this right now. It's super weird for me. like.. I can get them to work, but if I open the application then switch focus to something else, the windows don't go on top. If I run the application and then don't touch anything, there is a better chance they will stay on top. This is.. weird behavior.

kupoback commented 6 years ago

So you are able to replicate this? It's not just me being crazy?

nomns commented 6 years ago

No.. no... you aren't crazy. It was my fault (i'm the crazy one) -- my parser was using a different framework previously, so all these little things that worked before are done a little differently in Qt. I just fixed some stuff on my end. Apparently if an item wasn't toggled on with geometry set, the on top flag wasn't being set. I've now (a) force set on top regardless whether the window is showing at start (b) coupled the 'on top' toggle with clicking on the 'move' icon for the parsing windows, so (a) will force it to start and (b) will allow you to force toggle it on and off.

I didn't catch this previously cause it always worked on my end. :( So, with your current install it SHOULD work if:

  1. open parser.
  2. toggle parsing windows on so you can see them.
  3. make sure the parsers are frameless.
  4. exit he program using the system tray 'quit'.
  5. open your program again -- windows should be on top?

I am currently getting new maps together so I can do a release, but as soon as I get those updated, Ill update the master git so you can get the new script. The executable release should be out mid week.

kupoback commented 6 years ago

Ahhh, that makes sense. Well, I'm glad you were quickly able to find the issue and resolve it!

I look forward to updating my local copy!

nomns commented 6 years ago

Hey do another clone and check it out -- master git is updated to v0.4 pre release.

I am still having problems but I hope its workable.

Nm, still not working. Even weirder, it works better when i run it within a debugger.

nomns commented 6 years ago

Ok, give it a shot now.

I'll be on testing the Z system tonight so ill be around. Let me know if this fix is working !

kupoback commented 6 years ago

Seemed to work when i re-cloned it