search

nomns / nparse

Nomns' Parser for Project1999
GNU General Public License v3.0
43 stars 22 forks source link

Crashes on special characters in the log file #8

Closed dg891 closed 5 years ago

dg891 commented 5 years ago

Special characters in the log file like "《" or "》" cause the program to crash.

nomns commented 5 years ago

I will look into this today.

nomns commented 5 years ago

I was able to use the program both in source form and executable form while spamming 《 or 》and was not able to crash it (windows 10 64, source run in 64 bit, exe run as 32 bit).

Can you give me more details? Using the latest version? Running from executable or source? If source, what operating system? Were the items in a macro? If so, what else is in the macro? Are you able to reproduce?

edit: spelling and stuffs.

dg891 commented 5 years ago

[Wed Aug 22 19:04:23 2018] Mignonette says, ' 《 pst 》 c2／gob／e／vog／sos／etc~'

This is the specific line causing the crash. It is happening on the 0.4 version, running from executable. WIndows 10 64-bit.

The crash occurs every time that line is executed.

nomns commented 5 years ago

Great! Thanks for the updated info. I was able to reproduce the crash (UnicodeDecodeError).

I'll make a fix and push a new release tonight!

nomns commented 5 years ago

Newly released v0.4.1 should fix these problems. Please let me know if you have any problems.