nomns / nparse

Nomns' Parser for Project1999
GNU General Public License v3.0
43 stars 22 forks source link

Parser Window Refactor #82

Closed token419 closed 4 months ago

token419 commented 4 months ago

Refactored the base ParserWindow class.

Changed the base class from a QFrame to a QWidget. We were not using anything that QFrame required. I think this will also make testing easier as well.

Added a "name" var to be required when instantiating ParserWindow. This allowed us to move the logic for autohide/clickthrough/always on top into the parser window instead of the consumers of the class.

Added a config entry for frameless (not visible to the user) which now gets triggered when the windows goes framed/frameless. Reworked logic for this as a result which cleaned up a few window display issues. Mainly where if you closed a window via the taskbar or using the X on the window frame, then re opened.

Hooked up the "window_flush" config setting to now update on settings change instead of application restart.

Removed the need for some function calls and removed others that were not being used ever.

Renamed all internal class methods to be _underscore named