search

nomoixyz / vulcan

Development framework for Foundry projects
https://nomoixyz.github.io/vulcan/
MIT License
286 stars 18 forks source link

Update Accounts.sol #217

Closed 0xScratch closed 11 months ago

0xScratch commented 11 months ago

Same as #177

Fixed some typo errors within the comments

gnkz commented 11 months ago

Hey @Aryan9592! Thanks for contributing to vulcan. As we discussed before https://github.com/nomoixyz/vulcan/pull/177 we are not worried about optimizations since this is a library meant to be used on a dev environment so we prefer clarity over optimizations. This time we cannot accept the optimizations changes on the loops but the fixes on typos are more than welcome!

We love contributions tho, we are really grateful and please keep them coming! 🖖

Also if you are using Vulcan in your projects we are actually looking for feedback so we would appreciate any comments you have about modules, codebase, project structure, docs, etc.

0xScratch commented 11 months ago

Ohk, then I should revert back the changes except the typos fixes

0xScratch commented 11 months ago

Closing #218